linkml / linkml-runtime

Runtime support for linkml generated models
https://linkml.io/linkml/
Creative Commons Zero v1.0 Universal
22 stars 21 forks source link

Issue 1627 #279

Closed pkalita-lbl closed 10 months ago

pkalita-lbl commented 10 months ago

Fixes https://github.com/linkml/linkml/issues/1627

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 73.85% and project coverage change: +0.20% :tada:

Comparison is base (74d699c) 65.86% compared to head (b04b0e3) 66.06%. Report is 50 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #279 +/- ## ========================================== + Coverage 65.86% 66.06% +0.20% ========================================== Files 56 60 +4 Lines 7613 7700 +87 Branches 2012 2021 +9 ========================================== + Hits 5014 5087 +73 - Misses 2009 2024 +15 + Partials 590 589 -1 ``` | [Files Changed](https://app.codecov.io/gh/linkml/linkml-runtime/pull/279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linkml) | Coverage Δ | | |---|---|---| | [linkml\_runtime/linkml\_model/validation.py](https://app.codecov.io/gh/linkml/linkml-runtime/pull/279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linkml#diff-bGlua21sX3J1bnRpbWUvbGlua21sX21vZGVsL3ZhbGlkYXRpb24ucHk=) | `0.00% <0.00%> (ø)` | | | [linkml\_runtime/loaders/loader\_root.py](https://app.codecov.io/gh/linkml/linkml-runtime/pull/279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linkml#diff-bGlua21sX3J1bnRpbWUvbG9hZGVycy9sb2FkZXJfcm9vdC5weQ==) | `69.84% <54.28%> (+3.17%)` | :arrow_up: | | [linkml\_runtime/dumpers/rdf\_dumper.py](https://app.codecov.io/gh/linkml/linkml-runtime/pull/279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linkml#diff-bGlua21sX3J1bnRpbWUvZHVtcGVycy9yZGZfZHVtcGVyLnB5) | `65.90% <55.55%> (-5.89%)` | :arrow_down: | | [linkml\_runtime/utils/context\_utils.py](https://app.codecov.io/gh/linkml/linkml-runtime/pull/279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linkml#diff-bGlua21sX3J1bnRpbWUvdXRpbHMvY29udGV4dF91dGlscy5weQ==) | `73.77% <60.00%> (+5.43%)` | :arrow_up: | | [linkml\_runtime/loaders/delimited\_file\_loader.py](https://app.codecov.io/gh/linkml/linkml-runtime/pull/279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linkml#diff-bGlua21sX3J1bnRpbWUvbG9hZGVycy9kZWxpbWl0ZWRfZmlsZV9sb2FkZXIucHk=) | `82.85% <82.85%> (ø)` | | | [linkml\_runtime/dumpers/json\_dumper.py](https://app.codecov.io/gh/linkml/linkml-runtime/pull/279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linkml#diff-bGlua21sX3J1bnRpbWUvZHVtcGVycy9qc29uX2R1bXBlci5weQ==) | `77.77% <84.61%> (-1.54%)` | :arrow_down: | | [linkml\_runtime/loaders/yaml\_loader.py](https://app.codecov.io/gh/linkml/linkml-runtime/pull/279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linkml#diff-bGlua21sX3J1bnRpbWUvbG9hZGVycy95YW1sX2xvYWRlci5weQ==) | `92.30% <85.71%> (+1.00%)` | :arrow_up: | | [linkml\_runtime/utils/schemaview.py](https://app.codecov.io/gh/linkml/linkml-runtime/pull/279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linkml#diff-bGlua21sX3J1bnRpbWUvdXRpbHMvc2NoZW1hdmlldy5weQ==) | `87.79% <88.88%> (ø)` | | | [linkml\_runtime/dumpers/delimited\_file\_dumper.py](https://app.codecov.io/gh/linkml/linkml-runtime/pull/279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linkml#diff-bGlua21sX3J1bnRpbWUvZHVtcGVycy9kZWxpbWl0ZWRfZmlsZV9kdW1wZXIucHk=) | `89.65% <89.65%> (ø)` | | | [linkml\_runtime/dumpers/\_\_init\_\_.py](https://app.codecov.io/gh/linkml/linkml-runtime/pull/279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linkml#diff-bGlua21sX3J1bnRpbWUvZHVtcGVycy9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | ... and [12 more](https://app.codecov.io/gh/linkml/linkml-runtime/pull/279?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linkml) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/linkml/linkml-runtime/pull/279/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linkml)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pkalita-lbl commented 10 months ago

@cmungall Can you double-check that these changes are still inline with what you were doing in https://github.com/linkml/linkml-runtime/pull/248