Closed sujaypatil96 closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
51d2fce
) 62.80% compared to head (54d9515
) 62.90%. Report is 5 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
After wonderful optimizations by Jonny in https://github.com/linkml/linkml-runtime/pull/296 I thought this would be an appropriate time to take advantage of his modifications and apply it to large schemas (like mixs) that need this performance improvement.
@cmungall thanks for approving this PR. I'm still benchmarking if it's easier/faster to return ClassDefinition
instead of ClassDefinitionName
(corresponding changes will be required in slot.md.jinja2).
I won't merge this in till I have results from the benchmarking. I'm experimenting with these changes on the mixs schema.
I think we are good to go with this PR as is @cmungall.
The motivation to optimize this PR is that we are having to remove the Applicable classes section in the generated slot markdown/web documentation pages: https://github.com/linkml/linkml/blob/main/linkml/generators/docgen/slot.md.jinja2#L36-L46 for large schemas like mixs.
The optimizations that have been applied here are:
set()
for accumulating class namesself.all_classes()