Closed sneakers-the-rat closed 3 months ago
Attention: Patch coverage is 0%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 62.70%. Comparing base (
ed36311
) to head (0f99716
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
linkml_runtime/utils/schemaview.py | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
phew! +1 to the need for https://github.com/linkml/linkml-runtime/pull/316
https://github.com/linkml/linkml-runtime/pull/313 changed the if/else switch in selecting ordering to raise an exception for an unknown value rather than fall through because doing so exposes bugs like this one!
specifically, the
docgen
tests were all failing on a call toslot_children
because they were passing imports as a positional argument rather than a kwarg. Looking for all usages betweenlinkml_runtime
andlinkml
for the two methodsall_slots
andall_classes
that callordered
, and this looks like the only time that happens, everywhere else passes nothing or passes kargsbonus! now we honor that
imports
param :)