linkml / linkml

Linked Open Data Modeling Language
https://linkml.io/linkml
Other
295 stars 91 forks source link

plantuml generator does not handle mixins correctly and breaks diagram generation #2141

Open jsnyder-csdisco opened 3 weeks ago

jsnyder-csdisco commented 3 weeks ago

Describe the bug When using mixins in a schema , the generated plantuml puml file output generates plantuml syntax that does not parse correctly because proper spacing is missing.

To reproduce Given this schema fragment:

  Person:
    is_a: IdentifiableThing
    description: A LegalEntity that is a person.
    mixins:
     - LegalEntity

The generated diagram will have galEntity as the name and the uses relationship will also be "broken". The problem is that spacing between ALL the operators in plantuml syntax need spaces and there are missing.

Expected behavior Diagram should support mixin notation in the diagrams.

About your computer (if applicable, please complete the following information):

Additional context I have a fix for this as well as adding "ToolTip" output in plantuml text file to create hover text in SVGs for each class.

jsnyder-csdisco commented 3 weeks ago

I can add a PR if there is interest.

sujaypatil96 commented 2 weeks ago

Thanks @jsnyder-csdisco!! A PR would be very appreciated. Feel free to tag me as a reviewer after after you've made the PR.