search

linkml / linkml

Linked Open Data Modeling Language
https://linkml.io/linkml
Other
311 stars 98 forks source link

Genplantuml fixes improvements #2157

Closed jsnyder-csdisco closed 3 months ago

jsnyder-csdisco commented 3 months ago

Fixes for spacing and quoting PlantUML structures and adding support for Tooltip Text in PlantUML so that SVG can contain descriptions when you hover.

jsnyder-csdisco commented 3 months ago

I don't know why these three extra files got added to this PR.

jsnyder-csdisco commented 3 months ago

Part of this fix is import because my models cannot properly generate diagrams with mixins and other. In some cases several objects are dropped from diagram generation.

sujaypatil96 commented 3 months ago

@jsnyder-csdisco not sure if you've looked at this PR from @VladimirAlexiev before: https://github.com/linkml/linkml/pull/2060?

The state in which you have your code right now is the state in which plantumlgen.py was when @Silvanoc originally wrote the generator in the library. After that it has been modified by @VladimirAlexiev to remove quotation marks.

We can certainly add them back and i think your comment above answers the question posed by @Silvanoc here: https://github.com/linkml/linkml/pull/2060#discussion_r1577309102

We'll wait for a day/two to see if @VladimirAlexiev has any concerns/objections since he was the one who requested that we remove the quotation marks.

sujaypatil96 commented 3 months ago

Mostly everything on this PR looks good @jsnyder-csdisco 😁 As discussed, no rush, but if you could limit the files on this PR to just the ones that are critical/relevant, we can get this PR merged in soon after!

Thank you for your work on this!!