search

linkml / linkml

Linked Open Data Modeling Language
https://linkml.io/linkml
Other
298 stars 90 forks source link

Excel generator docs point to SQL DDL rather than Excel output #978

Closed mogul closed 1 year ago

mogul commented 1 year ago

Describe the bug The link to sample output from the Excel generator points to SQL DDL rather than a .xlsx file

To Reproduce Steps to reproduce the behavior:

  1. Go to https://linkml.io/linkml/generators/excel.html#example-output
  2. Click on 'personinfo.xlsx'
  3. See DDL for setting up an SQL DB

Expected behavior See an Excel file ready to be filled in.

cmungall commented 1 year ago

Thanks! This was due to an old bug in the naming of files, it was fixed but we need to regenerate all the artefacts, we'll take care of this after our workshop next week

sierra-moxon commented 1 year ago

@joshmoore - thank you for your SQLDDL generator ticket (#985). :) Here is another ticket that expresses a similar (same) issue. I'll tag you here on the earlier ticket so you can get notified when a fix comes in.

sierra-moxon commented 1 year ago

From @joshmoore:

Describe the bug

https://github.com/linkml/linkml/pull/608 updated the personinfo schema derived artifacts, but apparently the CREATE TABLE commands were stored in the personinfo.xlsx rather than the spreadsheet itself:

(linkml) /opt/linkml/examples/PersonSchema/personinfo $diff sqlschema/personinfo.sql excel/personinfo.xlsx
(linkml) /opt/linkml/examples/PersonSchema/personinfo $
joshmoore commented 1 year ago

Thanks, @sierra-moxon, and sorry for not checking first :wink:

sujaypatil96 commented 1 year ago

See PR #996 for fix