search

linkml / prefixmaps

Semantic prefix map registry
https://linkml.io/prefixmaps/
Apache License 2.0
10 stars 3 forks source link

62 fix omim #63

Closed amc-corey-cox closed 5 months ago

amc-corey-cox commented 5 months ago

Quick fix to the load_multi_context function that appears to fix the issue with OMIM being dropped.

Added a context for Monarch KG in the etl_runner so Monarch can keep ownership of the file merged.monarch.csv to watch out for changes that might be breaking.

amc-corey-cox commented 5 months ago

I had written this longer summary earlier but decided this is better in the comments section. This provides a quick fix to the load_multi_context function that appears to fix the issue with OMIM being dropped. I'm still unclear why this is happening.

Separately, I've added a context for Monarch KG in the etl_runner similar to merged.oak that is an exact copy of merged and merged.oak. These can now diverge if necessary and Monarch can keep ownership of the file merged.monarch.csv to watch out for changes that might be breaking.

amc-corey-cox commented 5 months ago

I have elected not to run etl_runner for this PR so we don't add complexity. If you want me to do etl_runner and resubmit, I'm happy to. I suppose I don't know if GitHub runs etl_runner automatically... if so we may need to reconsider that for center cases, i.e. merged.oak and merged.monarch.