Spaces and Multiple Monitors don't work properly with Tint Colors, Hide Desktop, and Invert Hue

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Use spaces or a second monitor
2. Only primary monitor will reflect tinting and hue changes
3. Only the space active when either switching from day to night, or when
the settings were applied will reflect the change
4. Change to a different space, hue and tinting go back to defaults

What is the expected output? What do you see instead?
The settings set in the preferences should stay intact across all spaces
and second displays

What version of the product are you using? On what operating system?
1.0.4

Please provide any additional information below.
Only the active space and the primary display will hold settings set in the
preferences.  Switching to other spaces will change the view back to the
default settings for night.  Switching back to the original space that the
settings were set in and everything goes back to the way it should. 
Preferences settings do not change when switching spaces, ie all settings
are global but the spaces don't reflect that.  Only 1 space gets the
settings from the preferences all others get the default.  

From my limited knowledge of mac programming, it seems like the settings
are only applied to the primary screen when the program tweaks the display
 parameters.  It is leaving out secondary and whatever spaces uses to
define the separate spaces.

Original issue reported on code.google.com by mgillogly@gmail.com on 6 Dec 2007 at 3:38

[GoogleCodeExporter]

I forgot to mention I am using Mac OS 10.5.1

Original comment by mgillogly@gmail.com on 6 Dec 2007 at 3:39

[GoogleCodeExporter]

After playing around with the source code I figured out the issue with dual 
monitors.
 There is a QSCIFilterWindow object named overlayWindow in the QSNocturneController.h
file.  I was able to make dual displays work by creating a second object that I 
named
overlayWindow2 and everywhere in project code where overlayWindow was used, I 
did the
same thing to overlayWindow2.  Also, instead of using [NSScreen mainScreen] when
selecting the frame for the overlayWindow I used [[NSScreen screens] 
objectAtIndex:0]
where 0 is the primary monitor and 1 is the secondary monitor.  This is a very 
dirty
approach to fixing this, but I figured this could same you some time and point 
you in
the right direction on how to fix this issue in a more efficient way.  I also 
found a
bug with the show desktop background option.  It only worked on one monitor as 
well.
 I found a workaround using a similar manner of duplicating code...

Original comment by mgillogly@gmail.com on 6 Dec 2007 at 6:31

Attachments:

• QSNocturneController.m
• QSNocturneController.h

[GoogleCodeExporter]

Invert Hue has the same issue. It looks like the only thing that works on dual
monitors is the basic inversion (on Leopard, at least, I have 10.5.4 currently).
Invert Hue, Hide Desktop, and Tint Colors all don't work. Strangely, Monochrome 
does
work across multiple monitors.

Original comment by papercr...@gmail.com on 13 Aug 2008 at 10:06

[GoogleCodeExporter]

I've created a patch that should support hue inversion for any number of 
monitors. It
may also fix Spaces, but I haven't checked that. This does not fix "Use Tint" or
"Hide Desktop" (yet).

Original comment by papercr...@gmail.com on 14 Aug 2008 at 3:03

Attachments:

• multi_screen_patch.diff

[GoogleCodeExporter]

There is another issue with my patch. If you remove (or probably add) a 
monitor, the
inversion gets set double....somehow....

Original comment by papercr...@gmail.com on 14 Aug 2008 at 3:05

[GoogleCodeExporter]

The monitor remove/add bug is fixed in this version of the patch (r2).

Original comment by papercr...@gmail.com on 14 Aug 2008 at 4:56

Attachments:

• multi_screen_patch_r2.diff

[GoogleCodeExporter]

Here's a last version of my patch (for tonight at least ;-) which fixes Invert 
Hue,
Hide Desktop, and Tint Colors for multiple displays. Tint Colors and Hide 
Desktop
both work for Spaces as well. Hide Desktop and Invert Hue work fine when adding 
or
removing displays.

Known Issues:
* Invert Hue does *not* work for Spaces
* Tint Colors gets removed when adding or removing displays (I suspect this is 
the
same as the iTunes issue #2)

Original comment by papercr...@gmail.com on 14 Aug 2008 at 6:27

Attachments:

• multi_screen_patch_r3.diff

[GoogleCodeExporter]

I figured out the one line that was giving me a warning. This patch fixes that 
warning.

Original comment by papercr...@gmail.com on 14 Aug 2008 at 5:03

Attachments:

• multi_screen_patch_r4.diff

[GoogleCodeExporter]

Tint Color, Hide Desktop, and Invert Hue all work on multiple monitors now.

Hide Desktop and Invert Hue now work when switching Spaces or when adding or 
removing
monitors.

Tint Colors does *not* work yet when adding/removing monitors or when switching 
spaces.

Original comment by papercr...@gmail.com on 15 Aug 2008 at 8:42

• Changed state: Started

[GoogleCodeExporter]

Marking as Fixed. Will use Issue #2 for remaining Tint problems.

Original comment by papercr...@gmail.com on 15 Aug 2008 at 8:44

• Changed title: Spaces and Multiple Monitors don't work properly with Tint Colors, Hide Desktop, and Invert Hue
• Changed state: Fixed