search

linktohack / evil-space

vim-space for evil-mode
GNU General Public License v2.0
11 stars 3 forks source link

Add more motions #1

Closed PythonNut closed 9 years ago

PythonNut commented 9 years ago

Hello, I'm working on a similar, but orthogonal, project. I had already compiled a list of motions (and their inverses) that are suitable for repetition.

Here, I've added them to the default config, should you desire to have a more complete collection of motions. If you do not, I would understand as repeating some motions (h and l for example) makes little sense. However, some of the added motions would be very convenient to repeat. # and * for example are both very useful, but rather far from the home row, and difficult to repeat.

If you'd like to keep some motions, but not the others, that can be arranged.

linktohack commented 9 years ago

Hi @PythonNut, thanks for your pull request. I totally agree on search and block motions.

However, I would like to keep the balance of number of motions and convenience. Please consider a case when you do a search / and then moving around h, j, w, b... would like to retain SPC as find next instead of next line...

gj and gk maybe good ones though.

What do you think? Can you please rebase and split the pull requrest into two smaller commit so I can merge it?

-QL

PythonNut commented 9 years ago

Yes, I quite agree, actually.

Would you rather I just remove h/j/k/l and force-push the commit to update? I'm not entirely sure what splitting the commit in two would do (as we intend to discard one).

linktohack commented 9 years ago

Well, just in case you want to keep the word and line motions...

If you're fine with discarding them, please do so :)

PythonNut commented 9 years ago

Alright, done.