linktohack / evil-space

vim-space for evil-mode
GNU General Public License v2.0
11 stars 3 forks source link

Add optional keymap parameter to evil-space-setup #2

Closed hlissner closed 9 years ago

hlissner commented 9 years ago

A proposal for an optional fourth parameter for evil-space-setup that dictates the keymap for lookups.

This way users who use plugins that have their own keymaps 'n motion bindings can have some o' that evil-space love.

Examples

e.g. (for evil-snipe)

(let ((map (evil-get-auxiliary-keymap evil-snipe-mode-map 'motion)))
  (evil-space-setup "s" "C-;" "C-," map)
  (evil-space-setup "S" "C-," "C-;" map))

or (evil-visualstar)

(let ((map (evil-get-auxiliary-keymap evil-visualstar-mode-map 'visual)))
  (evil-space-setup "*" "n" "N" map)
  (evil-space-setup "#" "n" "N" map)))
linktohack commented 9 years ago

Good idea!

Do you mind add some description to the docstring of evil-space-setup about keymap? Just your example above make sense. Otherwise I will do...

Thanks!

hlissner commented 9 years ago

And done. I hope it's to your liking!

linktohack commented 9 years ago

Thanks @hlissner, very nice!