linkwarden / browser-extension

Browser extension for Linkwarden
GNU Affero General Public License v3.0
146 stars 12 forks source link

extension is not working with SSO #45

Open cycomanic opened 6 months ago

cycomanic commented 6 months ago

The extension is not working with SSO (oauth2) at the moment. No rush (I know oauth2 just landed), just wanted to document it here.

crkos commented 6 months ago

Hello, I just pushed into dev a version that fixes this, If you can install it in your browser and let me know if it's working for you that would be great!

crkos commented 6 months ago

Make sure to check the new options on the Config window on the extension

apo2k7 commented 5 months ago

Hi! Thank you for adding the SSO login feature. I tried it with the Brave browser. Worked perfectly!

laxmanpradhan commented 5 months ago

any chance this version could be pushed to the firefox add-on store? Thanks!

https://addons.mozilla.org/en-US/firefox/addon/linkwarden/

crkos commented 5 months ago

Hello, I'm currently working on an OpenAPI specification of the API for linkwarden, I haven't tested this for firefox which will be definitly not work, because i havent modified the manifest and i'm not sure some browser apis i'm using work with firefox and V2 extensions, until i havent done that, i can't upload to the store, However it will be done soon. Worst case i have to mantain two versions of this.

alceasan commented 5 months ago

I could help with testing if there is any available build to install.

crkos commented 5 months ago

If you have npm you can compile it with npm run build then do as the readme says, just install the folder name dist

chrisbsmith commented 5 months ago

This worked for me (thanks!), but I got a warning that I needed to supply a username/password even with the Use SSO checkbox checked. I used my username name, but a dummy value for the password. Auth worked and I'm able to save links, so just some small UI/UX things to work out.

crkos commented 5 months ago

Yeah thats actually something i was thinking about, since it will shift the content every time you would click on it (or just make them not required), I just leave it there, but if you prefer like that i can just render it based on that, I actually doesnt matter if you provide username/password when SSO is checked is just UI validation nothing is sent to the server othen than checking if there is a session active.

crkos commented 5 months ago

Currently i dont have much time to work on it, Whats left to jump to next version is working the firefox (manifest v2...) version, it shouldn't take much effort is just modifying the manifest and a few things, It will be soon on the stores to just add it to browser, also a few features are already in, such as omnibox, context right click to add the page and automatic sync even if you dont add from the extension but the local bookmark it will be added to linkwarden

chrisbsmith commented 5 months ago

Yeah thats actually something i was thinking about, since it will shift the content every time you would click on it (or just make them not required), I just leave it there, but if you prefer like that i can just render it based on that, I actually doesnt matter if you provide username/password when SSO is checked is just UI validation nothing is sent to the server othen than checking if there is a session active.

I agree with your thoughts, but when I tried to auth with SSO checked, the validation failed that the username/password boxes were not populated.

crkos commented 5 months ago

Yes that is intented to happen, Even though not needed

crkos commented 5 months ago

I will probably remove it in the release