Open cycomanic opened 6 months ago
Hello, I just pushed into dev a version that fixes this, If you can install it in your browser and let me know if it's working for you that would be great!
Make sure to check the new options on the Config window on the extension
Hi! Thank you for adding the SSO login feature. I tried it with the Brave browser. Worked perfectly!
any chance this version could be pushed to the firefox add-on store? Thanks!
Hello, I'm currently working on an OpenAPI specification of the API for linkwarden, I haven't tested this for firefox which will be definitly not work, because i havent modified the manifest and i'm not sure some browser apis i'm using work with firefox and V2 extensions, until i havent done that, i can't upload to the store, However it will be done soon. Worst case i have to mantain two versions of this.
I could help with testing if there is any available build to install.
If you have npm you can compile it
with npm run build
then do as the readme says, just install the folder name dist
This worked for me (thanks!), but I got a warning that I needed to supply a username/password even with the Use SSO
checkbox checked. I used my username name, but a dummy value for the password. Auth worked and I'm able to save links, so just some small UI/UX things to work out.
Yeah thats actually something i was thinking about, since it will shift the content every time you would click on it (or just make them not required), I just leave it there, but if you prefer like that i can just render it based on that, I actually doesnt matter if you provide username/password when SSO is checked is just UI validation nothing is sent to the server othen than checking if there is a session active.
Currently i dont have much time to work on it, Whats left to jump to next version is working the firefox (manifest v2...) version, it shouldn't take much effort is just modifying the manifest and a few things, It will be soon on the stores to just add it to browser, also a few features are already in, such as omnibox, context right click to add the page and automatic sync even if you dont add from the extension but the local bookmark it will be added to linkwarden
Yeah thats actually something i was thinking about, since it will shift the content every time you would click on it (or just make them not required), I just leave it there, but if you prefer like that i can just render it based on that, I actually doesnt matter if you provide username/password when SSO is checked is just UI validation nothing is sent to the server othen than checking if there is a session active.
I agree with your thoughts, but when I tried to auth with SSO checked, the validation failed that the username/password boxes were not populated.
Yes that is intented to happen, Even though not needed
I will probably remove it in the release
The extension is not working with SSO (oauth2) at the moment. No rush (I know oauth2 just landed), just wanted to document it here.