search

linkwarden / browser-extension

Browser extension for Linkwarden
GNU Affero General Public License v3.0
147 stars 12 forks source link

Feature Request: Dark theme #49

Open NightMean opened 6 months ago

NightMean commented 6 months ago

Hi, thanks for making this extension! :)

As linkwarden itself supports dark theme, it would be great addition if extension would support it as well. What I would like is either toggle in the config or that the extension would respect the Linkwarden/System settings.

crkos commented 6 months ago

Hello thanks for the suggestion, of course, since we are using shadcn ui, This will be easy to implement, It will probably be shipped on the next update, i'm doing some automating sync when bookmarking if wanted on the options of the extension, So just wait some it will be shipped along with it!

NightMean commented 6 months ago

Perfect, thanks a lot ! I'll happily wait :)

crkos commented 6 months ago

Dark theme was implemented!, if you wish to install right now i would advise to check "dev" branch, if not wait until the update on stores, I'm working on some updates for the extension that would resolve this, #45 and #36

NightMean commented 3 months ago

Whoa, thanks for the quick implementation! :) Apologize for late reply, I've just tested that and it works as expect. Can't wait for the update. Just one minor thing, the initial config screen is still white without taking in account the system dark theme. Not sure if this is how you wanted it or if it was forgotten by mistake.

image

crkos commented 3 months ago

Yeah i think that is due to those being completly different pages, so i didnt remember that while doing it, that will be solved on the next update

arnavpraneet commented 2 months ago

Hi, unrelated to that but I saw you mentioned right click to save in context menu in this issue, are you still working on the update/is it done already? I was trying my hand at it but I am very new to extensions and all and haven't had much luck. Thanks!

crkos commented 2 months ago

Hello, you should be able to right click on any web page and be able to add the link

arnavpraneet commented 2 months ago

Does this work on the latest version on Firefox or Chrome? I tried with both from the extension store, didn't work for me. Nothing in the context menu.

crkos commented 2 months ago

It should appear like this, It supported on both: contextmenu

arnavpraneet commented 2 months ago

Still no dice, not working for either. Anything I can check to see what's wrong? Sorry a little new to this stuff

crkos commented 2 months ago

I dont really know what could be wrong, It is there, I mean unless someone has the same problem, I cant really know for sure what could be the problem

crkos commented 2 months ago

Well if you want send a ss of the context menu when you right click on a page.

arnavpraneet commented 2 months ago

Understandable, I will check it on other systems to see if its affecting my system only, and wait for if anyone has the same problem. Thanks for your time! I will attach an SS of the context menu when I right click on a page as well. image image first screenshot when right clicking on a link, second when you right click on the page without selecting any link.

crkos commented 2 months ago

If this goes on please just make a new issue, because this thread is about something else.

daniel31x13 commented 2 months ago

@arnavpraneet could you confirm if you’re on the latest version of the extension?

arnavpraneet commented 2 months ago

yes @daniel31x13, shall I make a new issue now?