search

linkwarden / browser-extension

Browser extension for Linkwarden
GNU Affero General Public License v3.0
147 stars 12 forks source link

Please don't hog Ctrl+Shift+V or at least give the option to disable it #66

Closed xJayMorex closed 2 months ago

xJayMorex commented 3 months ago

Ctrl+Shift+V in Windows is paste data only (without formatting), which is a pretty important keyboard shortcut.

crkos commented 2 months ago

is Ctrl+Shift+F ok?

55683ec

xJayMorex commented 2 months ago

@crkos I'd vote Ctrl + Shift + D if that is available, because it would be pretty intuitive, given that Ctrl + D bookmarks the current page in Chrome natively.

crkos commented 2 months ago

Ok sure.

Edit: If i press Ctrl + Shift + D it opens the window for creating Bookmars + folders and stuff, Should it set it to that regardless of that?

xJayMorex commented 2 months ago

I don't want to be the one to decide, but I think if someone is using this great browser extension instead of the native bookmark manager of the browser, they probably wouldn't mind if it would be Ctrl + D even. That way, Ctrl + Shift + D is free for some future functionality (e.g. open bookmark manager window). Not sure if that would work.

gioxx commented 2 months ago

It would be perfect to let the user choose the shortcut but not propose a default one because it might conflict with other existing shortcuts. In browsers the CTRL+Shift+V is for pasting text without formatting and it is essential not to occupy the shortcut with anything else. Thanks!

crkos commented 2 months ago

The default will stay as: "default": "Ctrl+Shift+F", "mac": "Command+Shift+F"

If y'all want to change this go to {browser]://extensions/shortcuts

The shortcut is defined at build time, I dont know if it could change at runtime my guess it is, but i dont see the point on doing that since the browser already supports it