linmaogithub / pdfium

Automatically exported from code.google.com/p/pdfium
0 stars 0 forks source link

pdfium 32-bit builds have two unresolved warnings #100

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
After https://codereview.chromium.org/792953005/ resolved most pdfium warnings 
there are still two remaining in 32-bit builds:

core\src\fxcodec\codec\fx_codec_jpx_opj.cpp(59) : warning C4244: 'initializing' 
: conversion from 'OPJ_OFF_T' to 'OPJ_SIZE_T', possible loss of data
core\src\fxcodec\codec\fx_codec_jpx_opj.cpp(72) : warning C4244: '=' : 
conversion from 'OPJ_OFF_T' to 'OPJ_SIZE_T', possible loss of data

These should be investigated and corrected either by using 64-bit types 
throughout or by adding appropriate casts. When the warnings are resolved then 
WarnAsError can be enabled for the fxcoded project (see pdfium.gyp).

Original issue reported on code.google.com by brucedaw...@chromium.org on 6 Jan 2015 at 7:54

GoogleCodeExporter commented 9 years ago
Still happening?

Original comment by thestig@chromium.org on 4 Sep 2015 at 9:48

GoogleCodeExporter commented 9 years ago
A test build of pdfium (debug and release) shows no warnings. A test of 
intentionally introducing some warnings shows that WarnAsError is enabled.

Victory! Closing as fixed.

I don't know who did the final push to clean this up.

Original comment by brucedaw...@chromium.org on 4 Sep 2015 at 5:09