linmaogithub / pdfium

Automatically exported from code.google.com/p/pdfium
0 stars 0 forks source link

CPDF_LinkList methods made private #200

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I'm not sure whether such issues are accepted or not but I want to discuss 
about the issue on our usage on pdfium.

In core/include/fpdfdoc/fpdf_doc.h, there is a class named CPDF_LinkList.
In older versions, it exposes CountLinks and GetLink methods and we can easily 
get the list of links on a page but the current version only have 
GetLinkAtPoint.

We want to get access to GetPageLinks method but it's now private.

What is the reason do you make GetPageLinks private?

Thanks in advance,

Takashi Kawasaki

Original issue reported on code.google.com by espresso...@gmail.com on 5 Sep 2015 at 2:18

GoogleCodeExporter commented 8 years ago
The only guaranteed stable APIs are those in the public/ directory.  If your 
code is calling into PDFium's C++ code directly, then you risk breakage such as 
the above, as we tidy the code to incorporate better programming practices.  

These are private because they are not called outside of the class in PDFium 
itself.

Original comment by tsepez@chromium.org on 8 Sep 2015 at 5:22

GoogleCodeExporter commented 8 years ago
Oh, I see. I understand your grand plan.
And, also I found FPDFLink_Enumerate function on fpdfdoc.cpp.

But, sometimes, we need deeper access to PDF internals because the current 
pdfium implementation does not cover all of the PDF features.
More specifically, all I need is direct access to the dictionaries. But it 
seems pdfium does not provide us with the access.

Do you have any future plan to support such access?

Original comment by espresso...@gmail.com on 8 Sep 2015 at 5:46