search

linmaogithub / pdfium

Automatically exported from code.google.com/p/pdfium
0 stars 0 forks source link

Fix the checkdeps.py rules for PDFium #217

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
There is the ability to run buildtools/checkdeps/checkdeps.py in a standalone 
pdfium checkout, but it is noisy, and the layering rules aren't 100% 
well-defined.

In principle, public/ should define and depend on the fpdfsdk layer, the 
fpdfsdk layer sholud depend on the core layer and the core layer should be 
self-contained.

XFA makes things trickier; ideally we'd like xfa to depend only on core, and to 
have fpdfsdk depend on XFA in as few places as possible.

Original issue reported on code.google.com by tsepez@chromium.org on 15 Oct 2015 at 5:18

GoogleCodeExporter commented 8 years ago 
The one exception to XFA at the moment appears to be:
xfa/src/fxjse/src/runtime.cpp:#include 
"../../../../fpdfsdk/include/jsapi/fxjs_v8.h

I'd thought that fpdfsdk/.../jsapi/ (not fpdfsdk/.../javascript/) could be its 
own top-level layer so that both fpdfsdk and xfa can depend on it.

Original comment by tsepez@chromium.org on 15 Oct 2015 at 5:21

GoogleCodeExporter commented 8 years ago 
A word of advice to those who might come this way: check out the 
--resolve-dotdot flag to checkdeps.py.  PDFium requires it.

Original comment by tsepez@chromium.org on 15 Oct 2015 at 7:18