search

linmaogithub / pdfium

Automatically exported from code.google.com/p/pdfium
0 stars 0 forks source link

There are three different ways to assert in the code base. #219

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
~/Development/pdfium % git grep ASSERT|wc -l
1096
~/Development/pdfium % git grep FXSYS_assert|wc -l
71
~/Development/pdfium % git grep "assert("|grep -v FXSYS_assert|wc -l
466

We should pick one that gets standardized on. Given there is another bug to 
remove the FX_ wrappers from the numeric classes, standardizing on ASSERT makes 
the most sense I think.

Original issue reported on code.google.com by dsinclair@chromium.org on 15 Oct 2015 at 8:22

GoogleCodeExporter commented 8 years ago

Original comment by thestig@chromium.org on 16 Oct 2015 at 2:36