linnabrown / run_dbcan

Run_dbcan V4, using genomes/metagenomes/proteomes of any assembled organisms (prokaryotes, fungi, plants, animals, viruses) to search for CAZymes.
http://bcb.unl.edu/dbCAN2
GNU General Public License v3.0
138 stars 40 forks source link

run_dbcan hotpep output contains non-existent EC numbers #81

Closed Rob-murphys closed 2 years ago

Rob-murphys commented 2 years ago

The hotpep.out for run_dbcan contains non-existent EC numbers that seems to be a merging of multiple EC numbers, for example 3.2.1.13.2.1 which can be seen in the attached output. This seems to be a combination of 3.2.1.1 and 3.2.1.- with the .- omitted.

Hotpep.zip

linnabrown commented 2 years ago

We are updating the new version that removing Hotpep and adding eCAMI which can also look for the subfamily. You can try the new software instead. Thank you so much and happy holiday.

Rob-murphys commented 2 years ago

Oh cool! How come you are stopping the use of hotpep?

yinlabniu commented 2 years ago

We have developed a better tool called eCAMI. Others also found that hotpep's performance is not very good: https://doi.org/10.6084/m9.figshare.14370836.v1


From: Lamm-a @.> Sent: Monday, December 20, 2021 1:02 PM To: linnabrown/run_dbcan @.> Cc: Subscribed @.***> Subject: Re: [linnabrown/run_dbcan] run_dbcan hotpep output contains non-existent EC numbers (Issue #81)

Non-NU Email


Oh cool! How come you are stopping the use of hotpep?

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/linnabrown/run_dbcan/issues/81*issuecomment-998191732__;Iw!!PvXuogZ4sRB2p-tU!TvNcTSO1Zpk2eK7FJfyNMTgNz0R8Y-Vp0Vn_G1BujJ9hqZQScpS1SlSJoCuM$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AEXNKZSBEAYFQ7CJRXNBGFDUR54WFANCNFSM5KNV3UBQ__;!!PvXuogZ4sRB2p-tU!TvNcTSO1Zpk2eK7FJfyNMTgNz0R8Y-Vp0Vn_G1BujJ9hqZQScpS1SsRkaD1l$. Triage notifications on the go with GitHub Mobile for iOShttps://urldefense.com/v3/__https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!PvXuogZ4sRB2p-tU!TvNcTSO1Zpk2eK7FJfyNMTgNz0R8Y-Vp0Vn_G1BujJ9hqZQScpS1StpLWGgK$ or Androidhttps://urldefense.com/v3/__https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign*3Dnotification-email*26utm_medium*3Demail*26utm_source*3Dgithub__;JSUlJSU!!PvXuogZ4sRB2p-tU!TvNcTSO1Zpk2eK7FJfyNMTgNz0R8Y-Vp0Vn_G1BujJ9hqZQScpS1Sq-V6Bsx$. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Rob-murphys commented 2 years ago

Very cool stuff!! Is there an ETA on the release?

linnabrown commented 2 years ago

I have already updated just now. Please check the github. Also, since eCAMI could not integrated in PYPI so you had to git clone https://github.com/linnabrown/run_dbcan.git and eCAMI is integrated inside run_dbcan folder. And don't forget to pip install run_dbcan=3.0.2 to update

Rob-murphys commented 2 years ago

Many thanks, i will try this ASAP! So it is able to get the EC level resolution similar to Hotpep right?

yinlabniu commented 2 years ago

That's right. Even better is that the overview file now contains a column named EC numbers (extracted from eCAMI).


From: Lamm-a @.> Sent: Monday, December 20, 2021 1:58 PM To: linnabrown/run_dbcan @.> Cc: Yanbin Yin @.>; Comment @.> Subject: Re: [linnabrown/run_dbcan] run_dbcan hotpep output contains non-existent EC numbers (Issue #81)

Non-NU Email


Many thanks, i will try this ASAP! So it is able to get the EC level resolution similar to Hotpep right?

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/linnabrown/run_dbcan/issues/81*issuecomment-998227215__;Iw!!PvXuogZ4sRB2p-tU!V89ErPtslvLhn5MFrNymdW9UAGCNUCJemjyOYIK-kx8cexBFcJwNszIToJBa$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AEXNKZXYWNBTJYOPMLR5Q4DUR6DHBANCNFSM5KNV3UBQ__;!!PvXuogZ4sRB2p-tU!V89ErPtslvLhn5MFrNymdW9UAGCNUCJemjyOYIK-kx8cexBFcJwNs0WFvyBm$. Triage notifications on the go with GitHub Mobile for iOShttps://urldefense.com/v3/__https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!PvXuogZ4sRB2p-tU!V89ErPtslvLhn5MFrNymdW9UAGCNUCJemjyOYIK-kx8cexBFcJwNs3tT4VKP$ or Androidhttps://urldefense.com/v3/__https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign*3Dnotification-email*26utm_medium*3Demail*26utm_source*3Dgithub__;JSUlJSU!!PvXuogZ4sRB2p-tU!V89ErPtslvLhn5MFrNymdW9UAGCNUCJemjyOYIK-kx8cexBFcJwNs5HN0w5U$. You are receiving this because you commented.Message ID: @.***>

Rob-murphys commented 2 years ago

I can't express enough how cool and thankful I am you have done this! You guys do awesome work :)

linnabrown commented 2 years ago

Thank you.