search

linnabrown / run_dbcan

Run_dbcan V4, using genomes/metagenomes/proteomes of any assembled organisms (prokaryotes, fungi, plants, animals, viruses) to search for CAZymes.
http://bcb.unl.edu/dbCAN2
GNU General Public License v3.0
138 stars 40 forks source link

Bug fixed #96

Closed QiweiGe closed 2 years ago

QiweiGe commented 2 years ago

Fixed original cgc.out and the simplified cgc.out could generated in a same cgc.out file.

linnabrown commented 2 years ago

@QiweiGe Hi Qiwei, why you need to change the input file of simplify_output() to cgc_standard.out? We don't have the output file with this name.

yinlabniu commented 2 years ago

I asked him to do so. We simplify the cgc output so that it's easier to understand. It is already implemented in our website.

Yanbin

From: Le Huang @.> Sent: Wednesday, May 4, 2022 5:58 PM To: linnabrown/run_dbcan @.> Cc: Subscribed @.***> Subject: Re: [linnabrown/run_dbcan] Bug fixed (PR #96)

Non-NU Email

@QiweiGehttps://urldefense.com/v3/__https://github.com/QiweiGe__;!!PvXuogZ4sRB2p-tU!HfZ6ibzrb6dQK_xlvVDczIEfekF5ZhIyO__evW0rsLu3jcHQ9MnQ8a9BYtFFKB4UDeJg-d0ykL-MG011s8kh-w$ Hi Qiwei, why you need to change the input file of simplify_output() to cgc_standard.out? We don't have the output file with this name.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/linnabrown/run_dbcan/pull/96*issuecomment-1118008766__;Iw!!PvXuogZ4sRB2p-tU!HfZ6ibzrb6dQK_xlvVDczIEfekF5ZhIyO__evW0rsLu3jcHQ9MnQ8a9BYtFFKB4UDeJg-d0ykL-MG03GHrg95g$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AEXNKZQSQXNJAHKIWUO3NNTVIL6LHANCNFSM5VA7PS3A__;!!PvXuogZ4sRB2p-tU!HfZ6ibzrb6dQK_xlvVDczIEfekF5ZhIyO__evW0rsLu3jcHQ9MnQ8a9BYtFFKB4UDeJg-d0ykL-MG0364D6-pg$. You are receiving this because you are subscribed to this thread.Message ID: @.***>

linnabrown commented 2 years ago

@yinlabniu Thank you so much! Qiwei just told me he did not finish revising the code, and I found that this revision is still in the halfway. He said I can ignore this currently and he will PR the full revised version later.