linnaeushuang / pensieve-pytorch

MIT License
27 stars 10 forks source link

Critic and Actor Network are not sharing any parameters #9

Closed Rui-Chun closed 3 years ago

Rui-Chun commented 3 years ago

In your implementation, Critic and Actor Network are not sharing any parameters. This is different from the implementation in the original Pensieve.

This fundamentally changes how the critic network gets trained. This may explain why you found that the critic network is not very useful during the training.