Colouring/filtering bugs

[JobLeonard]

[JobLeonard]

Seems that -1 (or perhaps negative numbers in general) trips up the colours as implemented in the client.

• inconsistency (-1 is a zero value for the heatmap in one set, and not a zero value in another)
• legend mismatch with scatterplot and/or sparkline heatmap for some values

There are also problems with filtering in the Oligos_All set, which may or may not be related to these bugs.

[JobLeonard]

One issue is that I'm copying the color generating functions all over the plotters. What we should do is make generators for heatmaps, categorical, and whatever else we come up with. These generators would take an attribute, and based on the type of data and the min/max values, return a function that takes a data value and returns a colour scaled correctly for the data.

EDIT: Even better, an attribute and a colorMode string.

• [x] make generator for color function in util.js
• [x] update affected code
  • [x] scatterplot.js
  • [x] sparkline.js
  • [x] legend.js

[JobLeonard]

Adding clamping (see #108) will kind of happen as a side-effect of this fix, btw.

[JobLeonard]

Only one bug left: reloading when filtering a gene breaks the webpage - see #109