search

linnarsson-lab / loom-viewer

Tool for sharing, browsing and visualizing single-cell data stored in the Loom file format
BSD 2-Clause "Simplified" License
35 stars 6 forks source link

paint.directly()-related bugs in sparkline #123

Closed JobLeonard closed 6 years ago

JobLeonard commented 6 years ago

Umbrella issue for #117, #120 and a few other issues that don't have their own ticket.

The main cause is as follows: in sparklines, we distinguish between plotters that group data and do something with the groups (averaging, sorting, etc) before displaying, and plotters that display the raw data from left-to-right.

const boxPaint = {
    directly: barPaintDirectly,
    grouped: barPaintBoxPlot,
};

The error is that we don't include pixelRatio (the number representing pixel density) in the calculations of when to switch between them. Should be a simple fix.

JobLeonard commented 6 years ago

Other plotter affected by this: Text, in terms of text size.