search

linnarsson-lab / loom-viewer

Tool for sharing, browsing and visualizing single-cell data stored in the Loom file format
BSD 2-Clause "Simplified" License
35 stars 6 forks source link

'Heatmap' view is broken #23

Closed JobLeonard closed 8 years ago

JobLeonard commented 8 years ago

The passed attributes (which should be an array) are empty objects somehow. Probably broke something while refactoring heatmap.js and perhaps dropdown.js

JobLeonard commented 8 years ago

I do not know what the difference is between:

let colAttrKeys = Object.keys(dataState.currentDataset.colAttrs).sort().push("(gene)");

and

let colAttrKeys = Object.keys(dataState.currentDataset.colAttrs);
colAttrKeys.sort();
colAttrKeys.push("(gene)");

.. but the former didn't work and the latter does.

Fixed in 2c353df