Closed JobLeonard closed 8 years ago
Great! I have poor internet here on a little island off the west coast (but great seafood!). However if you assign me issues I'll be able to fix them on the train back on Saturday.
Sten
Skickat från min iPhone
11 aug. 2016 kl. 17:07 skrev Job van der Zwan notifications@github.com<mailto:notifications@github.com>:
So this turned into a rabbit hole inside a rabbit hole inside a rabbit hole, but I think we're at a stable enough point (although still broken around the edges) to merge back. I'm creating this pull request at 17:00 before going home; I'll do the merge tomorrow morning and then spend the rest of the day fixing everything that inevitably breaks as a result.
A whole lot of optimisations and other changes are also in this branch:
Not yet implemented: encoding the view settings in the URL. I have found a packagehttps://github.com/Sage/jsurl that should make this fairly trivial to implement together with react-router however, since it should be trivial to convert JS objects containing these view settings to (URL) strings and back.
There's enough merge conflicts to require a manual merge, and some things will break at first (specificaly, loom-server.py and the client-side will be out of sync after the merge, but that will be easy to fix because I know where the issues are. Undoubtedly other problems that will emerge as well).
You can view, comment on, or merge this pull request online at:
https://github.com/linnarsson-lab/Loom/pull/40
Commit Summary
File Changes
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/linnarsson-lab/Loom/pull/40, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKKagzyYYhaphYlL_lDfpv9e9kHHqIbMks5qezqIgaJpZM4JiOD7.
So this turned into a rabbit hole inside a rabbit hole inside a rabbit hole, but I think we're at a stable enough point (although still broken around the edges) to merge back. I'm creating this pull request at 17:00 before going home; I'll do the merge tomorrow morning and then spend the rest of the day fixing everything that inevitably breaks as a result.
react-router
<Canvas>
component and the plotting components that pass it apaint(conext, width, height)
function<Canvas>
takes care of its own resizing and re-rendering, automatically scaling to fit its parent divviewState
react-router
<Canvas>
component that does just that. Mostly working for genescape & landscape, still broken in heatmap & sparkline (which had otherviewState
-related bugs before anyway)A whole lot of optimisations and other changes are also in this branch:
react-select
, making it easier to find fields. (TODO: make the gene-fetching UI also use this).eslintrc
project.json
to require minimum versions of the many components usedNot yet implemented: encoding the view settings in the URL. I have found a package that should make this fairly trivial to implement together with
react-router
however, since it should be trivial to convert JS objects containing these view settings to (URL) strings and back.There's enough merge conflicts to require a manual merge, and some things will break at first (specificaly,
loom-server.py
and the client-side will be out of sync after the merge, but that will be easy to fix because I know where the issues are. Undoubtedly other problems that will emerge as well).