linnarsson-lab / loom-viewer

Tool for sharing, browsing and visualizing single-cell data stored in the Loom file format
BSD 2-Clause "Simplified" License
35 stars 6 forks source link

Mass UI migration [was: try out collapsible sidebar component] #73

Closed JobLeonard closed 7 years ago

JobLeonard commented 7 years ago

So I was looking for sidebar components that we could use (after all, why re-invent the wheel if other people have battle-tested their own solutions for bugs and shared them online, right?)

... but then I came across this:

react-toolbox

The whole react-toolbox looks like a pretty amazing set of UI components to me. It comes with touch-support, sliders, autocomplete fields, everything.

Also, Google's Material Design comes with a lot of good visual design "defaults" in general (for example, the ripple effect when touching an button), and people will be familiar with it due to other websites.

Migrating to it from react-bootstrap might take a bit of work, and of course the whole interface will look very different, but I think it will be worth it. In the process we'll get a collapsible sidepanel, and a cleaner, more self-explanatory UI structure.

JobLeonard commented 7 years ago

One thing that must be fixed during this conversion, because it infuriates me: this visual bug where Canvas is set to the right pixel dimensions first, and then the browser adds the vertical scrollbar of the sidepanel, creating these blurry interference patterns on the sparklines.

image

image

JobLeonard commented 7 years ago

Competitor for react-toolbox: react-md. Will compare these two over the next few days before deciding which one I take.

https://react-md.mlaursen.com/components/autocompletes