linnarsson-lab / loom-viewer

Tool for sharing, browsing and visualizing single-cell data stored in the Loom file format
BSD 2-Clause "Simplified" License
35 stars 6 forks source link

Gene selection UI upgrade #76

Closed JobLeonard closed 7 years ago

JobLeonard commented 7 years ago

The placeholder logic can be relatively simple: doing a hash look-up on an undefined value in JS results in undefined, so we can just walk through the list of selected attributes/genes, and then only draw defined values.

The only thing that might be tricky is that if we're not careful, we re-render all sparklines (for example), every time one gene is fetched. I'd rather avoid that, since this can make the whole process rather slow (especially for datasets with tens of thousands of cells). I think that's actually happening right now, and the lag is notable for larger datasets on my laptop. Some caching in the sparkline view might be required here.