Open linnn-7 opened 5 months ago
No details provided by team.
[The team marked this bug as a duplicate of the following bug]
Overly restrictive check on phone numbers
Description The phone numbers that can be added are restricted to only 8 characters long and can only start with 8 or 9 as stated by the user guide, and in the error message when trying to input an invalid phone number. However, considering that the app is catered to making friends in dorms, this excludes exchange students who might not have a Singaporean number. Exchange students usually stay in dorms, and hence excluding them from being added might go against the aims of the app as it prevents you from befriending exchange students.
Steps to reproduce Enter any invalid phone number, that is either not 8 characters long or does not start with 8 or 9.
Expected behaviour App should accept greater variety of phone numbers, as contacts to be added do not necessarily have to have SIngaporean phone numbers.
Actual behaviour App rejects invalid phone numbers, e.g phone numbers that are not Singaporean.
Screenshots
Reason for severity This would prevent users from befriending foreign exchange students who might not have felt a need to get a Singaporean SIM card, which goes against the aim of the application. As many dorms host foreign exchange students, this can potentially affect many users. However, they can continue using the app by adding the foreign exchange student with a dummy number instead. However, there is no way of contacting these contacts with their actual phone number, which is quite a hindrance.
[original: nus-cs2103-AY2324S2/pe-interim#199] [original labels: severity.Medium type.FeatureFlaw]
[This is the team's response to the above 'original' bug]
The severity is bumped down to low as foreign students and local students will still be able to interact through other messaging platforms such as Telegram.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
Reason for disagreement: [replace this with your explanation]
Problem: Only allow users to input phone number that is 8-digits long and starts with an 8 or 9. This can be too restrictive, as users may need to store overseas phone numbers, and this can cause inconvenience.
Commands:
add n/lin p/21321423
Result: "Phone numbers must contain only numbers, be 8 digits long, and must start with an 8 or 9."Screenshot: