search

linnovate / mean-admin

Admin menu and features packages for mean
30 stars 19 forks source link

Theme images don't match the actual themes #21

Closed jdmcnair closed 10 years ago

jdmcnair commented 10 years ago

I don't know if it's a problem with the images or a problem with the themes themselves but the image files shown under /#!/admin/themes do not match the actual themes that they refer to.

The United theme, for instance, shows a purple navbar at the top:

image

jdmcnair commented 10 years ago

OK, a little more information... maybe this isn't an issue with the theme system.

It looks like the default layout at \packages\system\server\views\layouts\default.html is applying the navbar-inverse class on the navbar for some reason. I'm not sure if this makes for an issue per se, but it does make the user experience of the mean-admin module seem pretty wacky by default.

fyockm commented 10 years ago

Someone else submitted this a little while ago. Need to look back, but if I recall, we didn't want to change the default look of MEAN (i.e. the dark navbar). Just need to update the base CSS and remove navbar-inverse.

PR to main repo welcome if you want to handle.

jdmcnair commented 10 years ago

Created a pull request for this over on on the main mean repo.

fyockm commented 10 years ago

Thanks @jdmcnair. Closing this issue in favor of linnovate/mean#831.