linnovate / meanio

meanio core module
MIT License
54 stars 73 forks source link

Code Cleanup #129

Closed clowenhg closed 7 years ago

clowenhg commented 7 years ago

Several code cleanup changes.

adskjohn commented 7 years ago

Any reason behind deleting test/lib/mean_test.js vs. making it work? (assuming it doesn't)

clowenhg commented 7 years ago

It only really had two tests in it. One for aggregation which is gone, and one for menus which has been vastly improved in the actual menus test.

adskjohn commented 7 years ago

Cool, just wanted to make sure we're gaining or stay the same on coverage. The code looks good to me, so if you've locally tested and it all runs fine, I'm good to merge it :)