search

linnovate / meanio

meanio core module
MIT License
54 stars 73 forks source link

Compression on production #32

Closed AlmogBaku closed 8 years ago

AlmogBaku commented 9 years ago

see https://github.com/linnovate/mean/issues/753

https://github.com/expressjs/compression

pratik60 commented 9 years ago

I think we have enabled compression on express correctly

The three primary steps are there

var compression = require('compression');

app.use(compression()); //use compression 
app.use(express.static(path.join(__dirname, 'public')));

But I'm confused why its not working for the dist folder inside bower_components which is what the issue (https://github.com/linnovate/mean/issues/753) required?

AlmogBaku commented 9 years ago

where is it enabled? I couldn't find any refs for thats... =o

pratik60 commented 9 years ago

check config/express.js - its the recommended way also :-)

liorkesos commented 9 years ago

Hi guys -what is the verdict on this @pratik60 can you prepare an organized PR?

pratik60 commented 9 years ago

@liorkesos - Please close this. Its not the right issue, the correct issue is here => https://github.com/linnovate/mean/issues/753

Creating PR on both mean and meanio, and sending it in 10 minutes

ADSKLowenthal commented 8 years ago

@liorkesos Looks like this was resolved, and possibly not relevant anymore with the use of web pack.