search

linnovate / meanio

meanio core module
MIT License
54 stars 73 forks source link

having a substring "model" somewhere in the path causes app to crash #94

Open sometea opened 8 years ago

sometea commented 8 years ago

As described in linnovate/mean#1283

If the mean app has a name that contains a substring "model", then the app crashes while injecting the "circle" or "user" modules. This happens if the path of the app contains the substring "model". Out of curiosity, I had a look into this bug. It occurs due to the way the "type" of a path is checked in the walk function in util.js. I think I could fix this, will try to submit a PR later.

ADSKLowenthal commented 8 years ago

@sometea Did you have a chance to issue a PR? Is this still an issue?

sometea commented 8 years ago

I did, see #95 You seemed to have had some doubts with the solution though which I didn't fully comprehend, I can check again. I can also check if this is still an issue with current master.