lino-levan
commented
9 months ago How reliable is it for unit testing ?
One of my core design principles is RELIABILITY. I've always been frustrated with puppeteer and my hope with astral is to make it as reliable as playwright (if not more so).
Would it be possible to avoid the use of Deno.command for the browser installation?
I'd be willing to accept a PR to do this, though I'm slightly concerned about the performance implication of doing it in JS land. I don't care too much since most of the time installing the browser is spent downloading and not unzipping the file. If you're not willing to make a PR, I could look into it.
Similarly, would it be possible to be able to pass the cache path in getBinary() so it's possible to use the same cache as the app using it and have more controls about deno permissions ?
I'm not quite sure what you mean by this. Could you clarify? Are you asking for the ability to change the cache directory?
Definitely on the priority list, I've been meaning to add them.
This will most likely be an argument to launch. I've been waiting for someone to ask for this, it's a pretty trivial addition.
How do you achieve ... on astral to log console message from the browser to your app?
Right now it would require using the raw bindings, but I've been meaning to add more events. I'm curious what your usecase is. Is it just to log the page console? This shouldn't be too hard to add.
What's the equivalent of omitBackground for screenshot (unless it's enabled by default) ?
There isn't one currently, but I was really curious because it doesn't seem to exist as an option in the CDP protocol. After some investigation, I found out why.
Essentially, puppeteer just makes the background transparent for the screenshot and then undoes that. I'm not sure if this is the best way of doing that (it seems super race-y). I'm starting to wonder whether or not I should just expose the transparency emulation directly? Curious to hear your thoughts here.
Thanks for the comments and interest in astral! You make a lot of good points regarding how the library should move forward. I'm excited to hear back from you.
lowlighter
Hi ! I'm looking to possibly use this as a replacement of
npm:puppeteeras the later isn't designed for deno which seems to cause some troubles on windows (SIGHUP unsupported, instances not properly closing) and during unit testing (leaking ops)So I'm considering switching to astral, as the others puppeteer-like libs are either outdated or have some caveats from what I tested.
I have a few questions and possibly features requests (if this is in the project scope) though:
{ sanitizeResources: false, sanitizeOps: false }with puppeteer but the aim is to be able to have proper testing without any leaking ops (including windows).Deno.commandfor the browser installation ? On windows requiring the access ofPowershellwhich creates a big attack vector since you need to give a shell access. I haven't experimented it but it seems that it's possible to useDecompressionStreamto unzip the archive natively (ref: https://medium.com/deno-the-complete-reference/zip-and-unzip-files-in-deno-ee282da7369f)getBinary()so it's possible to use the same cache as the app using it and have more controls about deno permissions ?Page.setContent()Page.setViewport()Puppeteer.connect()page.on("console", (message: { text: () => string }) => console.debug("puppeteer: ${message.text()}"))andpage.on("pageerror", (error: { message: string }) => console.warn("puppeteer: ${error.message}"))on astral to log console message from the browser to your app ? Is it throughpage.addEventListeneromitBackgroundfor screenshot (unless it's enabled by default) ?Thanks in advance for your answer 😄 !