chore: Add userDataDir argument to LaunchOptions & validate write permission for tmp dir

lino-levan / astral

A high-level puppeteer/playwright-like library for Deno

https://jsr.io/@astral/astral

MIT License

176 stars 7 forks source link

chore: Add userDataDir argument to LaunchOptions & validate write permission for tmp dir #53

Closed Jess182 closed 1 day ago

Jess182 commented 3 months ago

Scenario

Currently there is a scenario where if the sandbox does not have write permissions it causes an exception when "launching" the browser, as it tries to create a temporary folder for "user data"

Proposal

This changes propose

Add userDataDir argument to LaunchOptions
Verify write permission for create tmp dir
Make --user-data-dir switch optional

Tests

lino-levan commented 3 months ago

Could you format your code?

lino-levan commented 1 day ago

Closing as this appears to be stale. Feel free to reopen another PR if the requirement strikes again.