lino-levan / astral

A high-level puppeteer/playwright-like library for Deno
https://jsr.io/@astral/astral
MIT License
248 stars 17 forks source link

Evaluating astral for Fresh #61

Closed marvinhagemeister closed 5 months ago

marvinhagemeister commented 5 months ago

I'm currently considering moving to astral for e2e testing for Fresh 2. We currently rely on a very old puppeteer instance. In Fresh we don't need much functionality so this seems like a perfect fit.

Here are some random thoughts while porting the test suite:

Overall it's a really nice experience. I love that it auto-installs chromium when not present. That's much better than what we had before. Looking forward to using it more 👍

lino-levan commented 5 months ago

There's definitely a bit of work to be done to make Astral smoother. Thanks for the feedback. History navigation should be a really easy ask if it's not already a part of Astral.

marvinhagemeister commented 5 months ago

Found out that uncaught exceptions and other things are dispatched as an event, so that was more me not knowing about it only. Got history navigation working as well by doing:

await page.evaluate(() => window.history.go(-1));
lino-levan commented 5 months ago

Closing because I think all of the individual points have been addressed through various PRs. Feel free to correct me if wrong.