linode / linode-blockstorage-csi-driver

Container Storage Interface (CSI) Driver for Linode Block Storage
Apache License 2.0
64 stars 54 forks source link

Configure the CSI driver through environment variables #170

Closed nesv closed 3 months ago

nesv commented 3 months ago

Within the Helm chart templates, the containers running linode-blockstorage-csi-driver were being configured with command-line flags where the flags' values were coming from environment variables. This commit removes the middle-man, and drops all of the CSI driver-specific command-line flags in favour of reading configuration values directly from the environment.

The Helm chart and kustomize templates have been updated accordingly.

General:

Pull Request Guidelines:

  1. [x] Does your submission pass tests?
  2. [ ] Have you added tests?
  3. [x] Are you addressing a single feature in this PR?
  4. [x] Are your commits atomic, addressing one change per commit?
  5. [x] Are you following the conventions of the language?
  6. [x] Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. [x] Have you explained your rationale for why this feature is needed?
  8. [ ] Have you linked your PR to an open issue
nesv commented 3 months ago

This pull request will need to be rebased onto main after #169 is merged.

nesv commented 3 months ago

Branch has been rebased.

Since this pull request includes a breaking change, I will bump the verison number to 0.8.0.