linode / linode-blockstorage-csi-driver

Container Storage Interface (CSI) Driver for Linode Block Storage
Apache License 2.0
64 stars 54 forks source link

Add golangci-lint configuration #171

Closed nesv closed 3 months ago

nesv commented 3 months ago

The golangci-lint configuration file contains some customized linter configurations, simply because not all of the linters that are enabled by default are worth it.

The "ci" workflow has also been modified a little. Namely, building the binary is done first as a quick and inexpensive check. If it successfully builds, then we go on to do the full-bore vet, staticcheck, linting, and tests.

General:

Pull Request Guidelines:

  1. [x] Does your submission pass tests?
  2. [ ] Have you added tests?
  3. [x] Are you addressing a single feature in this PR?
  4. [x] Are your commits atomic, addressing one change per commit?
  5. [ ] Are you following the conventions of the language?
  6. [ ] Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. [x] Have you explained your rationale for why this feature is needed?
  8. [ ] Have you linked your PR to an open issue