This pull request that cleans up the LinodeControllerServer (renamed to ControllerServer) in the internal/driver package.
What has changed
This is a brief overview of the changes that have been made in this pull request. Please note that these changes only pertain to the controller server.
Rename LinodeControllerServer to ControllerServer — the "Linode" prefix is somewhat redundant.
Organize code so that related things are in the same file.
Document all exported symbols (constants, variables, types, functions and methods).
Export some constants for documentation purposes — in some cases, having the constant exported so its documentation is readable can be helpful.
I have taken most of the "static" errors (ones that do not rely on context-specific information), and moved them into package-level sentinel errors, so they can be reused.
There are no changes in functionality, in this pull request. This pull request is only focused on cleaning up the existing code.
Notes for reviewers
When reviewing this pull request, please go through the branch commit-by-commit!
Attempting to review the whole change set in one go is likely to make things more difficult than they need to be.
General:
[x] Have you removed all sensitive information, including but not limited to access keys and passwords?
[x] Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?
Pull Request Guidelines:
[ ] Does your submission pass tests?
[ ] Have you added tests?
[ ] Are you addressing a single feature in this PR?
[x] Are your commits atomic, addressing one change per commit?
[x] Are you following the conventions of the language?
[ ] Have you saved your large formatting changes for a different PR, so we can focus on your work?
[x] Have you explained your rationale for why this feature is needed?
This pull request that cleans up the
LinodeControllerServer
(renamed toControllerServer
) in theinternal/driver
package.What has changed
This is a brief overview of the changes that have been made in this pull request. Please note that these changes only pertain to the controller server.
LinodeControllerServer
toControllerServer
— the "Linode" prefix is somewhat redundant.There are no changes in functionality, in this pull request. This pull request is only focused on cleaning up the existing code.
Notes for reviewers
When reviewing this pull request, please go through the branch commit-by-commit!
Attempting to review the whole change set in one go is likely to make things more difficult than they need to be.
General:
Pull Request Guidelines: