linode / linode-blockstorage-csi-driver

Container Storage Interface (CSI) Driver for Linode Block Storage
Apache License 2.0
64 stars 54 forks source link

internal/driver: Controller cleanup #186

Closed nesv closed 2 months ago

nesv commented 2 months ago

This pull request that cleans up the LinodeControllerServer (renamed to ControllerServer) in the internal/driver package.

What has changed

This is a brief overview of the changes that have been made in this pull request. Please note that these changes only pertain to the controller server.

There are no changes in functionality, in this pull request. This pull request is only focused on cleaning up the existing code.

Notes for reviewers

When reviewing this pull request, please go through the branch commit-by-commit!

Attempting to review the whole change set in one go is likely to make things more difficult than they need to be.

General:

Pull Request Guidelines:

  1. [ ] Does your submission pass tests?
  2. [ ] Have you added tests?
  3. [ ] Are you addressing a single feature in this PR?
  4. [x] Are your commits atomic, addressing one change per commit?
  5. [x] Are you following the conventions of the language?
  6. [ ] Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. [x] Have you explained your rationale for why this feature is needed?
  8. [ ] Have you linked your PR to an open issue
nesv commented 2 months ago

LGTM, thanks for the thorough commit messages and comments! 🙏

You are most welcome!


I am going to squash out the fixup commits prior to merging.

nesv commented 2 months ago

Squashed out fixup commits, and rebased onto main.