linode / linode-blockstorage-csi-driver

Container Storage Interface (CSI) Driver for Linode Block Storage
Apache License 2.0
64 stars 54 forks source link

go.mod: Update github.com/container-storage-interface/spec to v1.10.0 #190

Closed nesv closed 2 months ago

nesv commented 2 months ago

With the newer version of the package, the gRPC-ism requiring the "Unimplemented*Server" be embedded in the implementing struct has been enforced, and the NodeServer and IdentityServer implementations have been modified accordingly.

General:

Pull Request Guidelines:

  1. [x] Does your submission pass tests?
  2. [ ] Have you added tests?
  3. [x] Are you addressing a single feature in this PR?
  4. [x] Are your commits atomic, addressing one change per commit?
  5. [x] Are you following the conventions of the language?
  6. [x] Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. [x] Have you explained your rationale for why this feature is needed?
  8. [ ] Have you linked your PR to an open issue
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@603a7c7). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #190 +/- ## ======================================= Coverage ? 17.43% ======================================= Files ? 19 Lines ? 1262 Branches ? 0 ======================================= Hits ? 220 Misses ? 1019 Partials ? 23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.