linode / linode-blockstorage-csi-driver

Container Storage Interface (CSI) Driver for Linode Block Storage
Apache License 2.0
64 stars 54 forks source link

[Clean Up] - NodeStageVolume, NodeUnStageVolume, Adding golangci lint to GHA, and various small cleans #191

Closed komer3 closed 1 month ago

komer3 commented 1 month ago

General:

Pull Request Guidelines:

  1. [ ] Does your submission pass tests?
  2. [ ] Have you added tests?
  3. [ ] Are you addressing a single feature in this PR?
  4. [ ] Are your commits atomic, addressing one change per commit?
  5. [ ] Are you following the conventions of the language?
  6. [ ] Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. [ ] Have you explained your rationale for why this feature is needed?
  8. [ ] Have you linked your PR to an open issue
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 63.80952% with 152 lines in your changes missing coverage. Please review.

Project coverage is 37.16%. Comparing base (cad2ac1) to head (ea43ccc).

Files Patch % Lines
mocks/mock_nodeserver.go 48.03% 119 Missing :warning:
internal/driver/nodeserver.go 0.00% 17 Missing :warning:
internal/driver/nodeserver_helpers.go 92.79% 7 Missing and 1 partial :warning:
pkg/common/idhelpers.go 0.00% 2 Missing and 2 partials :warning:
main.go 0.00% 3 Missing :warning:
internal/driver/luks.go 96.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #191 +/- ## =========================================== + Coverage 17.43% 37.16% +19.73% =========================================== Files 19 22 +3 Lines 1262 1547 +285 =========================================== + Hits 220 575 +355 + Misses 1019 938 -81 - Partials 23 34 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

eljohnson92 commented 1 month ago

it looks like you need remove the ./mock directory from code coverage reporting here