linode / linode-blockstorage-csi-driver

Container Storage Interface (CSI) Driver for Linode Block Storage
Apache License 2.0
64 stars 54 forks source link

[fix] Address the errors we are seeing for NodeExpandVolume() in CSI-Sanity test #196

Closed komer3 closed 1 month ago

komer3 commented 1 month ago

The cases being addressed here from csi-sanity tests:

NOTE: This PR is not for implementing the NodeExpandVolume(). That method is in the roadmap for future PRs. This is just meant for address errors related to validation of the request object.

General:

Pull Request Guidelines:

  1. [ ] Does your submission pass tests?
  2. [ ] Have you added tests?
  3. [ ] Are you addressing a single feature in this PR?
  4. [ ] Are your commits atomic, addressing one change per commit?
  5. [ ] Are you following the conventions of the language?
  6. [ ] Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. [ ] Have you explained your rationale for why this feature is needed?
  8. [ ] Have you linked your PR to an open issue
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 36.40%. Comparing base (d4f9670) to head (69bc1eb).

Files Patch % Lines
internal/driver/nodeserver.go 0.00% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #196 +/- ## ========================================== + Coverage 36.39% 36.40% +0.01% ========================================== Files 22 22 Lines 1580 1596 +16 ========================================== + Hits 575 581 +6 - Misses 971 981 +10 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rahulait commented 1 month ago

Overall, the PR looks good to me.