linode / linode-blockstorage-csi-driver

Container Storage Interface (CSI) Driver for Linode Block Storage
Apache License 2.0
64 stars 54 forks source link

[Fix] Re-enable Readonly since we support mounting the volume in that mode on the Node Plugin side #201

Closed komer3 closed 3 weeks ago

komer3 commented 3 weeks ago

REASON: In my previous PR, I removed the functionality for read only volumes because according to the CSI-Driver spec we are suppose to create a read only volume on the Linode side. But Linode currently does not support that. To get around that, we are currently mounting the volume as read-only on the Node plugin side when we publish the volume. To avoid any issues with customer (who might be using it currently), I'm re-enabling it and just skipping the associated csi-sanity test case.

General:

Pull Request Guidelines:

  1. [ ] Does your submission pass tests?
  2. [ ] Have you added tests?
  3. [ ] Are you addressing a single feature in this PR?
  4. [ ] Are your commits atomic, addressing one change per commit?
  5. [ ] Are you following the conventions of the language?
  6. [ ] Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. [ ] Have you explained your rationale for why this feature is needed?
  8. [ ] Have you linked your PR to an open issue
codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.42%. Comparing base (a917258) to head (15cb849). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #201 +/- ## ========================================== + Coverage 36.38% 36.42% +0.03% ========================================== Files 22 22 Lines 1594 1595 +1 ========================================== + Hits 580 581 +1 Misses 980 980 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.