linode / linode-blockstorage-csi-driver

Container Storage Interface (CSI) Driver for Linode Block Storage
Apache License 2.0
64 stars 54 forks source link

[Cleanup] Nodepublishvolume() refactor #204

Closed komer3 closed 3 weeks ago

komer3 commented 3 weeks ago

This PR is refactoring one of the Node Plugins grpc methods called NodePublishVolume(). Its purpose is to mount a volume device (block or fs) to a given target directory inside of a particular pod.

Things that are refactored:

General:

Pull Request Guidelines:

  1. [ ] Does your submission pass tests?
  2. [ ] Have you added tests?
  3. [ ] Are you addressing a single feature in this PR?
  4. [ ] Are your commits atomic, addressing one change per commit?
  5. [ ] Are you following the conventions of the language?
  6. [ ] Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. [ ] Have you explained your rationale for why this feature is needed?
  8. [ ] Have you linked your PR to an open issue
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 79.06977% with 27 lines in your changes missing coverage. Please review.

Project coverage is 40.56%. Comparing base (d783f32) to head (1c92564). Report is 1 commits behind head on main.

Files Patch % Lines
internal/driver/nodeserver.go 0.00% 16 Missing :warning:
pkg/mount-manager/fs-utils.go 16.66% 10 Missing :warning:
main.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #204 +/- ## ========================================== + Coverage 36.73% 40.56% +3.83% ========================================== Files 22 24 +2 Lines 1598 1622 +24 ========================================== + Hits 587 658 +71 + Misses 977 930 -47 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.