linode / linode-blockstorage-csi-driver

Container Storage Interface (CSI) Driver for Linode Block Storage
Apache License 2.0
64 stars 54 forks source link

test ext2, ext3, ext4, xfs as supported filesystem type #206

Closed rahulait closed 2 weeks ago

rahulait commented 2 weeks ago

General:

This PR now tells upstream e2e tests to test ext2, ext3, ext4, xfs as well. This increases our total covered specs from 29 to 45. Here is sample output run: Before:

------------------------------
SSS
------------------------------
[SynchronizedAfterSuite] 
test/e2e/e2e.go:88
  Aug 23 15:21:12.453: INFO: Running AfterSuite actions on node 1
[SynchronizedAfterSuite] PASSED [0.000 seconds]
------------------------------
[ReportAfterSuite] Kubernetes e2e suite report
test/e2e/e2e_test.go:161
[ReportAfterSuite] PASSED [0.000 seconds]
------------------------------

Ran 29 of 7692 Specs in 2428.116 seconds
SUCCESS! -- 29 Passed | 0 Failed | 1 Flaked | 0 Pending | 7663 Skipped
PASS

After:

test/e2e/e2e.go:88
  Aug 27 16:22:15.516: INFO: Running AfterSuite actions on node 1
[SynchronizedAfterSuite] PASSED [0.000 seconds]
------------------------------
[ReportAfterSuite] Kubernetes e2e suite report
test/e2e/e2e_test.go:161
[ReportAfterSuite] PASSED [0.000 seconds]
------------------------------

Ran 45 of 7692 Specs in 4566.865 seconds
SUCCESS! -- 45 Passed | 0 Failed | 2 Flaked | 0 Pending | 7647 Skipped
PASS

Pull Request Guidelines:

  1. [x] Does your submission pass tests?
  2. [ ] Have you added tests?
  3. [x] Are you addressing a single feature in this PR?
  4. [x] Are your commits atomic, addressing one change per commit?
  5. [x] Are you following the conventions of the language?
  6. [x] Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. [x] Have you explained your rationale for why this feature is needed?
  8. [ ] Have you linked your PR to an open issue
codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.94%. Comparing base (b45e75c) to head (39c980a). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #206 +/- ## ======================================= Coverage 36.94% 36.94% ======================================= Files 23 23 Lines 1746 1746 ======================================= Hits 645 645 Misses 1067 1067 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

komer3 commented 2 weeks ago

Could enable running the upstream E2E tests for this PR temporarily?

rahulait commented 2 weeks ago

Could enable running the upstream E2E tests for this PR temporarily?

Sure, let me run them temporarily.

rahulait commented 2 weeks ago

All tests passed in the GHA run: https://github.com/linode/linode-blockstorage-csi-driver/actions/runs/10577227395/job/29315188886

test/e2e/e2e.go:88
  Aug 27 16:22:15.516: INFO: Running AfterSuite actions on node 1
[SynchronizedAfterSuite] PASSED [0.000 seconds]
------------------------------
[ReportAfterSuite] Kubernetes e2e suite report
test/e2e/e2e_test.go:161
[ReportAfterSuite] PASSED [0.000 seconds]
------------------------------

Ran 45 of 7692 Specs in 4566.865 seconds
SUCCESS! -- 45 Passed | 0 Failed | 2 Flaked | 0 Pending | 7647 Skipped
PASS