linode / linode-blockstorage-csi-driver

Container Storage Interface (CSI) Driver for Linode Block Storage
Apache License 2.0
64 stars 54 forks source link

[Cleanup] Replace Status.Error() with helper func() defined in errors.go #209

Closed komer3 closed 2 weeks ago

komer3 commented 2 weeks ago

Reason: We introduced errors.go with bunch of predefined errors and funcs() a while back and we want to make sure we use it in the code base to maintain uniformity and consistent error logging

General:

Pull Request Guidelines:

  1. [ ] Does your submission pass tests?
  2. [ ] Have you added tests?
  3. [ ] Are you addressing a single feature in this PR?
  4. [ ] Are your commits atomic, addressing one change per commit?
  5. [ ] Are you following the conventions of the language?
  6. [ ] Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. [ ] Have you explained your rationale for why this feature is needed?
  8. [ ] Have you linked your PR to an open issue
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 40.45%. Comparing base (9fbc7d5) to head (4e06aae). Report is 2 commits behind head on main.

Files Patch % Lines
internal/driver/nodeserver.go 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #209 +/- ## ========================================== - Coverage 40.56% 40.45% -0.12% ========================================== Files 24 24 Lines 1622 1619 -3 ========================================== - Hits 658 655 -3 Misses 930 930 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.