search

linode / linode-blockstorage-csi-driver

Container Storage Interface (CSI) Driver for Linode Block Storage
Apache License 2.0
64 stars 54 forks source link

[Cleanup] Refactor LinodeNodeServer for consistency #210

Closed komer3 closed 2 weeks ago

komer3 commented 2 weeks ago

This PR renames LinodeNodeServer to NodeServer and adjusts its fields to align with the naming conventions used in ControllerServer. Additionally, NewNodeServer() has been moved from driver.go to nodeserver.go to improve code organization.

Changes

These changes enhance code uniformity and maintainability across the codebase

General:

Pull Request Guidelines:

  1. [ ] Does your submission pass tests?
  2. [ ] Have you added tests?
  3. [ ] Are you addressing a single feature in this PR?
  4. [ ] Are your commits atomic, addressing one change per commit?
  5. [ ] Are you following the conventions of the language?
  6. [ ] Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. [ ] Have you explained your rationale for why this feature is needed?
  8. [ ] Have you linked your PR to an open issue
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 67.24138% with 19 lines in your changes missing coverage. Please review.

Project coverage is 37.40%. Comparing base (724f448) to head (3c551bd). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/driver/nodeserver.go 50.00% 17 Missing :warning:
internal/driver/driver.go 33.33% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #210 +/- ## ========================================== + Coverage 37.00% 37.40% +0.39% ========================================== Files 23 23 Lines 1751 1762 +11 ========================================== + Hits 648 659 +11 + Misses 1068 1067 -1 - Partials 35 36 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.