search

linode / linode-blockstorage-csi-driver

Container Storage Interface (CSI) Driver for Linode Block Storage
Apache License 2.0
68 stars 56 forks source link

[Refactor] Adding structured logging to Nodeserver #218

Closed komer3 closed 2 months ago

komer3 commented 2 months ago

This PR implements better logging functionality to help with current and future debugging. It adds Method names and traceID to logs to help follow the flow of the request and how it is resolved.

General:

Pull Request Guidelines:

  1. [ ] Does your submission pass tests?
  2. [ ] Have you added tests?
  3. [ ] Are you addressing a single feature in this PR?
  4. [ ] Are your commits atomic, addressing one change per commit?
  5. [ ] Are you following the conventions of the language?
  6. [ ] Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. [ ] Have you explained your rationale for why this feature is needed?
  8. [ ] Have you linked your PR to an open issue
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 47.69231% with 102 lines in your changes missing coverage. Please review.

Project coverage is 37.66%. Comparing base (767dd67) to head (35f7329). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/driver/nodeserver.go 7.50% 74 Missing :warning:
main.go 0.00% 11 Missing :warning:
pkg/logger/logger.go 47.36% 9 Missing and 1 partial :warning:
internal/driver/nodeserver_all.go 0.00% 5 Missing :warning:
internal/driver/controllerserver.go 0.00% 1 Missing :warning:
internal/driver/identityserver.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #218 +/- ## ========================================== + Coverage 37.08% 37.66% +0.58% ========================================== Files 23 24 +1 Lines 1777 1893 +116 ========================================== + Hits 659 713 +54 - Misses 1082 1143 +61 - Partials 36 37 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.