linode / linode-blockstorage-csi-driver

Container Storage Interface (CSI) Driver for Linode Block Storage
Apache License 2.0
68 stars 57 forks source link

[Refactor] Improved logging for Controller Server #222

Closed komer3 closed 2 months ago

komer3 commented 2 months ago

This PR replaces the use of klog with structured logging using the logger package in the controller server. Key changes include:

These changes enhance the observability of the controller server operations and make debugging easier by providing more structured and consistent log output.

General:

Pull Request Guidelines:

  1. [ ] Does your submission pass tests?
  2. [ ] Have you added tests?
  3. [ ] Are you addressing a single feature in this PR?
  4. [ ] Are your commits atomic, addressing one change per commit?
  5. [ ] Are you following the conventions of the language?
  6. [ ] Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. [ ] Have you explained your rationale for why this feature is needed?
  8. [ ] Have you linked your PR to an open issue
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 13.63636% with 57 lines in your changes missing coverage. Please review.

Project coverage is 38.78%. Comparing base (cf2f8c3) to head (755398e). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/driver/controllerserver.go 13.63% 57 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #222 +/- ## ========================================== + Coverage 38.59% 38.78% +0.18% ========================================== Files 24 24 Lines 1956 1952 -4 ========================================== + Hits 755 757 +2 + Misses 1165 1159 -6 Partials 36 36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.