linode / linode-blockstorage-csi-driver

Container Storage Interface (CSI) Driver for Linode Block Storage
Apache License 2.0
68 stars 57 forks source link

[Fix] nouuid flag for xfs mounting #230

Closed komer3 closed 2 months ago

komer3 commented 2 months ago

This change fixes errors when mounting cloned XFS volumes on the same node as the original. The issue occurred because both volumes had identical UUIDs. By adding the 'nouuid' flag during mounting, we bypass the duplicate UUID check, similar to how ext4 handles this situation. This solution resolves the mounting errors without compromising functionality.

General:

Pull Request Guidelines:

  1. [ ] Does your submission pass tests?
  2. [ ] Have you added tests?
  3. [ ] Are you addressing a single feature in this PR?
  4. [ ] Are your commits atomic, addressing one change per commit?
  5. [ ] Are you following the conventions of the language?
  6. [ ] Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. [ ] Have you explained your rationale for why this feature is needed?
  8. [ ] Have you linked your PR to an open issue
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 38.42%. Comparing base (52912b7) to head (5f4efff). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/driver/nodeserver_helpers.go 0.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #230 +/- ## ========================================== - Coverage 38.46% 38.42% -0.04% ========================================== Files 24 24 Lines 1955 1957 +2 ========================================== Hits 752 752 - Misses 1168 1169 +1 - Partials 35 36 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

srust commented 2 months ago

LGTM