linode / linode-blockstorage-csi-driver

Container Storage Interface (CSI) Driver for Linode Block Storage
Apache License 2.0
68 stars 56 forks source link

replace using cryptsetup binary for LUKS encryption with cryptsetup go pkg #232

Closed amold1 closed 2 months ago

amold1 commented 2 months ago

Summary:

This change replaces the use of cryptsetup binary for LUKS encryption with cryptsetup go pkg. The rationale for doing this is eloquently stated in the go pkg docs here

Related Changes;

Given this pkg uses underlying C libraries that are available only for linux systems and not macos, we are now moving our make targets to use docker containers(with an image created from dev dockerfile)

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 65.27197% with 83 lines in your changes missing coverage. Please review.

Project coverage is 40.13%. Comparing base (7276afc) to head (6cff550). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
mocks/mock_cryptsetupclient.go 69.64% 34 Missing :warning:
internal/driver/nodeserver.go 0.00% 15 Missing :warning:
pkg/cryptsetup-client/cryptsetup-client.go 36.36% 13 Missing and 1 partial :warning:
internal/driver/luks.go 81.25% 9 Missing and 3 partials :warning:
internal/driver/metadata.go 0.00% 2 Missing :warning:
internal/driver/nodeserver_helpers.go 90.00% 1 Missing and 1 partial :warning:
main.go 0.00% 2 Missing :warning:
pkg/mount-manager/device-utils.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #232 +/- ## ========================================== - Coverage 40.75% 40.13% -0.63% ========================================== Files 23 26 +3 Lines 1818 1936 +118 ========================================== + Hits 741 777 +36 - Misses 1043 1120 +77 - Partials 34 39 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.