linode / linode-blockstorage-csi-driver

Container Storage Interface (CSI) Driver for Linode Block Storage
Apache License 2.0
68 stars 56 forks source link

fix security issue for int conversion; remove sanity tests if clause #275

Closed amold1 closed 1 month ago

amold1 commented 1 month ago

General:

Pull Request Guidelines:

  1. [ ] Does your submission pass tests?
  2. [ ] Have you added tests?
  3. [ ] Are you addressing a single feature in this PR?
  4. [ ] Are your commits atomic, addressing one change per commit?
  5. [ ] Are you following the conventions of the language?
  6. [ ] Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. [ ] Have you explained your rationale for why this feature is needed?
  8. [ ] Have you linked your PR to an open issue
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.32%. Comparing base (6b98fa2) to head (4b370fb). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/driver/controllerserver.go 25.00% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #275 +/- ## ========================================== + Coverage 76.21% 76.32% +0.10% ========================================== Files 21 21 Lines 1619 1622 +3 ========================================== + Hits 1234 1238 +4 + Misses 288 286 -2 - Partials 97 98 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.